Bug found in logout.cgi of Ethernet Module

Hello,

I believe I found a bug in the logout.cgi file used by the gen 3 Ethernet module. I think after logging out it tries to return to the homepage (the ip address with no forward slash), but it is interpretting the IP address as a signed number when it shouldn’t. The end result is that logout.cgi sometimes tries to redirect you to a negative IP address.

For an example IP of 192.168.6.100, logout.cgi tries to redirect to “-64.-88.6.100”.
image

Can anyone else confirm this bug? Is there a different place I should report it?

@jacob please can you look into this

Hi,

I can confirm this bug. I will look into resolving it.

Hello,

I wanted to follow up on this bug report and see if there have been any patches released. I am almost done building my test fixture and wanted to see if I could fix this issue before the product is released.

Hi,

Yes. We’ve introduced a fix for this in firmware version 2.6 which, due to the holidays, was just released today: ncd_Ethernet/Firmware for Rev 2 Hardware/HRev2_NCD5500_V2.6_12-3-25.bin at main · ncd-io/ncd_Ethernet · GitHub

Excellent, thank you for working to fix this! I will update the firmware on my board and verify the fix in the next couple days.

Awesome, you will need to download the latest NCD Config Tool or update your html file (currently the only html file supported is the 8-channel html file) in order to see this configuration option.

Nevermind, my last comment only applies to the ability to disable the automatic logout via the web portal that was also added. The logout bug should be fixed just with the firmware update.

I can confirm the logout bug is fixed in version 2.6. Disabling automatic logout also works through the new NCD Config Tool and new html file.

Thank you for addressing these items!